On Thu, Aug 12, 2010 at 5:02 AM, Fujii Masao <masao.fujii@gmail.com> wrote:
> When I was enjoying reading the HS source code,
> I found some typos. Attached patch fixes them.
I've committed all of this except for the following, which I'm not
certain is correct:
--- a/src/backend/access/transam/clog.c
+++ b/src/backend/access/transam/clog.c
@@ -355,10 +355,10 @@ TransactionIdSetStatusBit(TransactionId xid, XidStatus sta /* * Update the group LSN
ifthe transaction completion LSN is higher. *
- * Note: lsn will be invalid when supplied during InRecovery processing,
- * so we don't need to do anything special to avoid LSN updates during
- * recovery. After recovery completes the next clog change will set the
- * LSN correctly.
+ * Note: lsn will be invalid when supplied while we're performing
+ * recovery but hot standby is disabled, so we don't need to do
+ * anything special to avoid LSN updates in that case. After recovery
+ * completes the next clog change will set the LSN correctly. */ if (!XLogRecPtrIsInvalid(lsn))
{
TransactionIdSetStatusBit is called from TransactionIdSetPageStatus,
which seems to think that the validity of lsn is based on whether
we're doing an async commit. Your change may be correct, but I'm not
certain of it...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company