Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to
Дата
Msg-id AANLkTikoPtDuL8vefTRaCXbofp-bpXPXPrmKV_VxURXv@mail.gmail.com
обсуждение исходный текст
Ответы Re: [COMMITTERS] pgsql: In walsender, don't sleep if there's outstanding WAL waiting to  (Fujii Masao <masao.fujii@gmail.com>)
Список pgsql-hackers
Hi,

On Thu, May 27, 2010 at 7:21 AM, Heikki Linnakangas
<heikki@postgresql.org> wrote:
> Log Message:
> -----------
> In walsender, don't sleep if there's outstanding WAL waiting to be sent,
> otherwise we effectively rate-limit the streaming as pointed out by
> Simon Riggs. Also, send the WAL in smaller chunks, to respond to signals
> more promptly.
>
> Modified Files:
> --------------
>    pgsql/src/backend/replication:
>        walsender.c (r1.20 -> r1.21)
>        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/replication/walsender.c?r1=1.20&r2=1.21)

This commit seems to have introduced the bug that walsender exits
before sending all the WAL up to shutdown checkpoint record when
smart shutdown is requested.

The attached patch fixes the bug and a tiny typo.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Heikki Linnakangas
Дата:
Сообщение: Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: Streaming Replication: Checkpoint_segment and wal_keep_segments on standby