Re: pg_dump's checkSeek() seems inadequate

Поиск
Список
Период
Сортировка
От Robert Haas
Тема Re: pg_dump's checkSeek() seems inadequate
Дата
Msg-id AANLkTiko4KJ0Bc8Rbw_7eby8r9vuNPSu_oLd6ImCqeQq@mail.gmail.com
обсуждение исходный текст
Ответ на pg_dump's checkSeek() seems inadequate  (Tom Lane <tgl@sss.pgh.pa.us>)
Ответы Re: pg_dump's checkSeek() seems inadequate  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
On Sun, Jun 27, 2010 at 1:42 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> If I change the test to be
>
>        fseeko(fp, 0, SEEK_SET)
>
> then it does the right thing.  Since checkSeek() is applied immediately
> after opening the input file this should be OK, but it does limit the
> scope of usefulness of that function.
>
> Any thoughts about whether or not to apply such a patch?  If it should
> be changed, should we back-patch it?

Well, I guess it depends on what you think the chances are that the
revised test will fail on some other obscure platform.  Have there
been any reports from the field?  If not, I might apply to HEAD and
await developments.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: [PATCH] Re: Adding XMLEXISTS to the grammar
Следующее
От: Tom Lane
Дата:
Сообщение: Re: pg_dump's checkSeek() seems inadequate