Re: Ticket 266: Unable to backup table when quotation marks used in the name
Hi Guillaume,
As long as I do remember, the commandLineClenOption() function was introduced, because of the command-line parameter behaves differently with quote on different platforms.
Though - I have tested your patch (Sorry - I do not have enough time to spend around pgAdmin now-a-days because of the work load).
But It will be good - if you can please test the patch on all the platform (specially on windows) with quote in the name for table, user-name, etc before applying this patch.
As long as I do remember, the commandLineClenOption() function was introduced, because of the command-line parameter behaves differently with quote on different platforms.
Though - I have tested your patch (Sorry - I do not have enough time to spend around pgAdmin now-a-days because of the work load).
But It will be good - if you can please test the patch on all the platform (specially on windows) with quote in the name for table, user-name, etc before applying this patch.
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company
On Thu, Nov 18, 2010 at 4:01 AM, Guillaume Lelarge <guillaume@lelarge.info> wrote:
Hi,
I worked on this bug since sunday evening, and it's really an annoying
one. We have an issue with objects' names containing double quotes when
doing a backup, whatever your OS is.
I found a fix, and I would usually commit it ASAP. But this time, I'm a
bit worried. I don't understand why the commandLineCleanOption()
function (in misc.c) is so complicated. There should be a reason.
Unfortunately, The fix I wrote deletes almost all of it.
If someone has an explanation of the function, I'm happy to hear it.
And if someone thinks my patch is just plain stupid, tell me before I
commit it :)
Thanks.
--
Guillaume
http://www.postgresql.fr
http://dalibo.com
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
В списке pgadmin-hackers по дате отправления:
Предыдущее
От: Guillaume LelargeДата:
Сообщение: Re: pgAdmin III commit: The enum alter query now requires LABEL keyword
Следующее
От: Guillaume LelargeДата:
Сообщение: Re: Ticket 266: Unable to backup table when quotation marks used in the name