Re: pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers

Hmm. If it's included in he linux installer but not the windows one, that looks like a bug in the windows installer to me. Is it an optoinal feature that can be turned on and off, or is it supposed to always be installed? (question directed at the installer guys, not you Jasmin! :P)

//Magnus

On Thu, Jan 6, 2011 at 18:19, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:

---------- Forwarded message ----------
From: Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com>
Date: 2011/1/6
Subject: Re: [pgadmin-hackers] pgAdmin III commit: Pull keywords dynamically from PostgreSQL headers
To: Ashesh Vashi <ashesh.vashi@enterprisedb.com>


OK, I've noticed now, that the file is only included in the linux binaries version. Maybe the pgadmin3/INSTALL File should be modified to make this clear - for beginners.

I had downloaded the windows version before.

Thank you for your help.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

I just downloaded one to cross check.
And as I suspect, they include those headers.

Please download it again (if possible).

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

On Thu, Jan 6, 2011 at 10:25 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:

From http://www.enterprisedb.com/products/pgbindownload.do two weeks ago.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

From where did you get it?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

On Thu, Jan 6, 2011 at 10:20 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:

unpacked zip. version is 8.4

should i build it from source?

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

how did you install it?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

On Thu, Jan 6, 2011 at 10:15 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:

the directory is there, but no gram.h.

2011/1/6 Ashesh Vashi <ashesh.vashi@enterprisedb.com>

Do you have %PGDIR%/include/postgresql/server/parser directory which contains gram.h?

--
Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company

 

http://www.linkedin.com/in/asheshvashi

On Thu, Jan 6, 2011 at 10:04 PM, Jasmin Dizdarevic <jasmin.dizdarevic@gmail.com> wrote:

Hi, 

since this patch is applied, i can't build pgAdmin. %pgdir%\include\server\parser doesn't contain a gram.h file. 

What I'm doing wrong?

Ty

Jasmin

2011/1/5 Magnus Hagander <magnus@hagander.net>

On Wed, Jan 5, 2011 at 06:05, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

On Wed, Jan 5, 2011 at 12:37 AM, Magnus Hagander <magnus@hagander.net> wrote:

On Tue, Jan 4, 2011 at 18:46, Ashesh Vashi <ashesh.vashi@enterprisedb.com> wrote:

Hi Magnus/Dave,

This check-in has added one compilation error.
The following line introduce an error in file 'pgadmin/db/keywords.c'
#include <server/parser/gram.h>
#include <server/parser/kwlist.h>

Because - these header files does not always find under `pg_config --includedir` folder, but can be found under `pg_config --pkgincludedir`.

Please find the patch to resolve the issue. This applies on both master and REL-1_12_PATCHES branch.

Looks good in general, but do we actually need to put it on 1.12? The keyword build changes were only applied to master, so unless we actually *need* it on the back branch, I don't think we should put it there.  Is it needed for something else as well?

You're right.
This patch should only be applied on master.

 Thanks, confirmed and applied.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/