Re: Bug in error reporting for multi-line JSON

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: Bug in error reporting for multi-line JSON
Дата
Msg-id A999DFE1-BD97-4E93-9EBF-55B386974C90@yesql.se
обсуждение исходный текст
Ответ на RE: Bug in error reporting for multi-line JSON  ("tanghy.fnst@fujitsu.com" <tanghy.fnst@fujitsu.com>)
Ответы Re: Bug in error reporting for multi-line JSON  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-bugs
> On 25 Aug 2021, at 10:22, tanghy.fnst@fujitsu.com wrote:
>
> On Tuesday, March 2, 2021 6:50 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> I'm changing the status of this patch to Ready for Committer.
>>
>> I reviewed this and pushed it, with some changes.
>
> I think the while condition "context_start < context_end" added in commit ffd3944ab9 is useless. Thoughts?
>
> code added in ffd3944ab9
> + while (context_end - context_start >= 50 && context_start < context_end)

Judging by the diff it’s likely a leftover from the previous coding.  I don’t
see a case for when it would hit, but it also doesn’t seem to do any harm apart
from potentially causing static analyzers to get angry.

--
Daniel Gustafsson        https://vmware.com/




В списке pgsql-bugs по дате отправления:

Предыдущее
От: "tanghy.fnst@fujitsu.com"
Дата:
Сообщение: RE: Bug in error reporting for multi-line JSON
Следующее
От: Neil Chen
Дата:
Сообщение: Re: BUG #17157: authorizaiton of dict_int and bloom extention