Re: Making jsonb_agg() faster

Поиск
Список
Период
Сортировка
От Chao Li
Тема Re: Making jsonb_agg() faster
Дата
Msg-id A8FC96CD-BA0E-43A2-A49D-B6C13030D34A@gmail.com
обсуждение исходный текст
Ответ на Re: Making jsonb_agg() faster  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers

> On Dec 6, 2025, at 07:14, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> v5, rebased over a couple of recent patches.  No substantive changes.
>
> I'd kind of like to get this pushed soon, because it keeps getting
> sideswiped ... does anyone have further comments?

Actually I traced v4 again this week. I tried to find out something to comment, but ended up I didn’t find anything
significant.

My only nit commit is still about the hard-coded 12:
```
+                case TIMETZOID:
+                    /* pass-by-reference */
+                    oldcontext = MemoryContextSwitchTo(outcontext);
+                    v->val.datetime.value = datumCopy(v->val.datetime.value,
+                                                      false, 12);
```

I commented this before and you explained. But I still think it may deserve a comment for why 12 is here, otherwise
futurereader may also get the same confusion as when I first time read this code. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







В списке pgsql-hackers по дате отправления: