Re: Optionally automatically disable logical replication subscriptions on error

> On Jun 20, 2021, at 10:11 PM, Amit Kapila  wrote:
> 
> However, I see a different case where there could be
> multiple failing xids and that can happen during initial table sync
> where multiple workers failed due to some error. I am not sure your
> patch would be able to capture all such failed transactions because
> you are recording this information in pg_subscription and not in
> pg_subscription_rel.

Right, I wasn't trying to capture everything, just enough to give the user a reasonable indication of what went wrong.  My patch was designed around the idea that the user would need to figure out how to fix the subscriber side prior to re-enabling the subscription.  As such, I wasn't bothered with trying to store everything, just enough to give the user a clue where to look.  I don't mind if you want to store more information, and maybe that needs to be stored somewhere else.  Do you believe pg_subscription_rel is a suitable location? 

—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company