On 28-Jul-05, at 10:46 AM, Oliver Jowett wrote:
> Dave Cramer wrote:
>
>> This just adds an exception to the existing backend exception showing
>> the originating query.
>>
>
> I think the basic idea is ok, but..
>
> - this should be on the original exception, not on a chained synthetic
> exception
Yeah, that would be cleaner.
> - doing it only in execute() seems incomplete, there are other query
> execution paths, perhaps this logic belongs somewhere in the query
> executor?
There are even more paths there to hook into. Putting it in
AbstractJdbc2Statement minimizes
the number of places it would need to be added to. QueryExecutor has
a few Implementations ...
> - ideally it should be configurable (hook it into whatever came out of
> Kris' suggestions about including more info in server-generated
> exception, perhaps?)
Well, lets get it working first before we make it configurable.
>
> -O
>
>