Re: [bug fix] psql's \conninfo reports incorrect destination on Windows

Поиск
Список
Период
Сортировка
От MauMau
Тема Re: [bug fix] psql's \conninfo reports incorrect destination on Windows
Дата
Msg-id A03704845EA14382A6E0F407F5884E0E@maumau
обсуждение исходный текст
Ответ на Re: [bug fix] psql's \conninfo reports incorrect destination on Windows  (Fujii Masao <masao.fujii@gmail.com>)
Ответы Re: [bug fix] psql's \conninfo reports incorrect destination on Windows  (Fujii Masao <masao.fujii@gmail.com>)
Список pgsql-hackers
From: "Fujii Masao" <masao.fujii@gmail.com>
> I think that 77035fa8a92d8c39f4c689e54f46813f203f09a8 fixed this problem.
> Please check that.

I looked through your patch.  I'm fine with the PQhostaddr().  I didn't 
notice the problem when hostaddr was passed to psql on Windows.

OTOH, regarding PQhost(), I think we had better take my patch. 
connectOptions2() computes and set derived values to PGconn, so that 
PGconn's members have values which are actually used for connection.  To 
follow that rule, PGconn->pghost may as well have "localhost" on machines 
without UNIX domain sockets.  Plus, if we want to refer to the actual 
connection target for libpq implementation in other places than PQhost(), we 
can just use PGconn's members.  If we do so, we don't have to change 
PQhost().

Could you replace the patch?

Regards
MauMau




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alexander Korotkov
Дата:
Сообщение: Re: GIN improvements part2: fast scan
Следующее
От: Rajeev rastogi
Дата:
Сообщение: Re: Proposal for CSN based snapshots