> >If there are no further comments from Claudio or anyone else, I feel
> >this is now ready to be applied.
Code walkthrough looks good.
One final minor point to discuss:
Is being unable to set a handler for things like CTRL_C_EVENT,
CTRL_SHUTDOWN_EVENT etc really a non-fatal error? ISTM that, if we can't
guarantee to cleanly handle externally generated signals (like a shutdown
request) or those that could occur internally (like, say, SIGFPE, which I'm
guessing you'll get to), then we probably ought to bail.
Either way, I agree that we ought to get this patch in as is.
Cheers,
Claudio
---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>