Bug in fd.c (FreeFile)

Поиск
Список
Период
Сортировка
От Claudio Natoli
Тема Bug in fd.c (FreeFile)
Дата
Msg-id A02DEC4D1073D611BAE8525405FCCE2B028047@harris.memetrics.local
обсуждение исходный текст
Список pgsql-patches
I believe FreeFile has an "off by one" type error. Apart from possibly
accessing past the end of the array, when combined with the while loop call
from CleanupTempFiles, it contrives to fail to fclose a number of files [at
a guess, floor((numAllocatedFiles-1)/2)] when CleanupTempFiles is called
(unless I'm completely mistaken).

Change 1: Begin search from "correct" [logical] final element of array
Change 2: Minor speed-up to CleanupTempFiles (knowing that FreeFile iterates
from the [logical]
final element of the array)

Apply to HEAD (bug also exists in 7.4 branch, possibly others...)

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>



Вложения

В списке pgsql-patches по дате отправления:

Предыдущее
От: Christopher Kings-Lynne
Дата:
Сообщение: Re: minor cleanup in plpgsql.sgml
Следующее
От: Claudio Natoli
Дата:
Сообщение: Re: Bug in fd.c (FreeFile)