On 08/04/2019 20:37, Andres Freund wrote:
> Hi,
>
> On 2019-04-08 15:34:46 +0300, Heikki Linnakangas wrote:
>> There were a bunch of typos in the comments in tableam.h, see attached. Some
>> of the comments could use more copy-editing and clarification, I think, but
>> I stuck to fixing just typos and such for now.
> I pushed these after adding three boring changes by pgindent. Thanks for
> those!
>
> I'd greatly welcome more feedback on the comments - I've been pretty
> deep in this for so long that I don't see all of the issues anymore. And
> a mild dyslexia doesn't help...
Here is another iteration on the comments. The patch is a mix of
copy-editing and questions. The questions are marked with "HEIKKI:". I
can continue the copy-editing, if you can reply to the questions,
clarifying the intention on some parts of the API. (Or feel free to pick
and push any of these fixes immediately, if you prefer.)
- Heikki