On 3/30/18 03:30, Edmund Horner wrote:
> On 30 March 2018 at 19:26, Fabien COELHO <coelho@cri.ensmp.fr> wrote:
>> Thanks for the check. You might consider turning the patch as ready in the
>> cf app.
>
> Ok, I have done so, since the patch is small and simple.
>
>>> Fixing the abs/hash bracketing seems clear. The wasn't sure about
>>> rewriting "mod(i, bj)" as "mod(i, j)", because there could be some
>>> convention about parameter names, but I can't think of anything the "b"
>>> could be in the case of mod.
>>
>>
>> Might be a left-over a previous version which might have used MOD(a, b), but
>> a/b are rather used for fp numbers and i/j for integers.
>
> Ah that seems possible.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services