Hi Srinath
On 23.07.25 09:03, Srinath Reddy Sadipiralla wrote:
> +1 for the patch,i have reviewed and tested this patch, except these
> below cosmetic changes it LGTM.
>
> cosmetic changes:
> 1) add comment about %i in get_prompt api.
Done.
> 2) maybe we can use read-write instead of read/write to be consistent
> with the
> naming such as options of target_session_attrs uses read-write.
I believe that 'read/write' is more idiomatic than 'read-write' in this
context. 'Read-only' works as a hyphenated adjective, and 'read/write'
is typically treated as a paired label that indicates two distinct
capabilities --- read and write. What do you think?
v3 attached.
Thanks for the thorough testing and review!
Best, Jim