planstate_tree_walker oversight CustomScan

Поиск
Список
Период
Сортировка
От Kouhei Kaigai
Тема planstate_tree_walker oversight CustomScan
Дата
Msg-id 9A28C8860F777E439AA12E8AEA7694F801148C64@BPXM15GP.gisp.nec.co.jp
обсуждение исходный текст
Ответы Re: planstate_tree_walker oversight CustomScan  (Robert Haas <robertmhaas@gmail.com>)
Список pgsql-hackers
Hi,

The planstate_tree_walker() oversight custom_ps of CustomScanState;
that should be a list of underlying PlanState object if any.

ExplainPreScanNode() treated ForeignScan and CustomScan in special
way (it is sufficient for ExplainPreScanNode() purpose), thus, it
didn't implement its recursive portion originally.

The job of ExplainPreScanNode() is know all the relids involved
in a particular subquery execution. On the other hands, fs_relids
of ForeignScan and custom_relids of CustomScan informs a set of
relids to be scanned by this Scan node without recursive, so it
did not have recursive walks on the underlying sub-plans.

However, planstate_tree_walker() will have different expectation.
It is general walker routine, thus, it is natural users to expect
the callback is also kicked towards the underlying planstate of
CustomScan (and ForeignScan; once EPQ recheck gets solved).

The attached patch adds support of CustomScan on the walker.

Thanks,
--
NEC Business Creation Division / PG-Strom Project
KaiGai Kohei <kaigai@ak.jp.nec.com>


Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Stephen Frost
Дата:
Сообщение: Re: row_security GUC, BYPASSRLS
Следующее
От: "Daniel Verite"
Дата:
Сообщение: Re: [patch] Proposal for \rotate in psql