Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation

Поиск
Список
Период
Сортировка
От MauMau
Тема Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation
Дата
Msg-id 994F3C8171ED42D7898F0795DCD6ACAA@maumau
обсуждение исходный текст
Ответ на Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation  (Amit Kapila <amit.kapila16@gmail.com>)
Ответы Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation  (Amit Kapila <amit.kapila16@gmail.com>)
Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation  (Andres Freund <andres@2ndquadrant.com>)
Re: [bug fix] PostgreSQL fails to start on Windows if it crashes after tablespace creation  (Tom Lane <tgl@sss.pgh.pa.us>)
Список pgsql-hackers
From: "Amit Kapila" <amit.kapila16@gmail.com>
> If you think that above scenario is not possible, then you just need to
> modify comment:
> "!  * Remove old symlink in recovery...."

Hm, my scenario seems impossible.  I reverted the comment.


> One more minor point about patch:
> + struct stat st;
>
> if (InRecovery)
> {
> struct stat st;
>
> Defining stat struct two times in same function in different ways doesn't
> seem to be good, we can do the same way for new usage as is already
> done in code or may be declare it once.

OK, I removed the second (existing) definition of st.

Regards
MauMau

Вложения

В списке pgsql-hackers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG
Следующее
От: Etsuro Fujita
Дата:
Сообщение: Re: inherit support for foreign tables