On 2018/02/09 2:58, Alvaro Herrera wrote:
> Robert Haas wrote:
>> On Wed, Feb 7, 2018 at 3:42 AM, Ashutosh Bapat
>> <ashutosh.bapat@enterprisedb.com> wrote:
>
>>> partition.c seems to have two kinds of functions 1. that build and
>>> manage relcache, creates quals from bounds etc. which are metadata
>>> management kind 2. partition bound comparison functions, and other
>>> optimizer related functions. May be we should divide the file that
>>> way. The first category code remains in catalog/ as it is today. The
>>> second catagory functions move to optimizer/.
>>
>> It would be sensible to separate functions that build and manage data
>> in the relcache from other functions. I think we should consider
>> moving the existing functions of that type from partition.c to
>> src/backend/utils/cache/partcache.c.
>
> FWIW I've been thinking that perhaps we need some other separation of
> code better than statu quo. The current partition.c file includes stuff
> for several modules and ISTM all these new patches are making more and
> more of a mess. So +1 to the general idea of splitting things up.
> Maybe partcache.c is not ambitious enough, but it seems a good first
> step.
Agree with the proposed reorganizing and adding a partcache.c, which I
tried to do in the attached patch.
* The new src/backend/utils/cache/partcache.c contains functions that
initialize relcache's partitioning related fields. Various partition
bound comparison and search functions (and then some) that work off of the
cached information are moved. Also, since we cache partition qual,
interface functions RelationGetPartitioQual(Relation) and
get_partition_qual_relid(Oid) are moved too.
* The new src/include/utils/partcache.h contains various struct
definitions that are moved from backend/catalog/partition.c,
include/catalog/partition.h, and include/utils/rel.h. Also, declarations
of interface functions of partcache.c.
Thoughts?
Thanks,
Amit