Re: Is it really such a great idea for spi.h to include the world?

Alvaro Herrera <alvherre@commandprompt.com> writes:
> Bruce Momjian wrote:
>> Tom Lane wrote:
>>> I propose changing spi.h to follow the same include-only-what-you-must
>>> rule as every other backend header file.  Thoughts?
>> 
>> I don't think we ever cleaned out spi.h in the past because we were
>> worried about 3rd party code using it (I am fine with a cleanup).

> I've wondered about spi.h lately too while looking at header cleanup,
> and I agree with the proposed solution.  The worst that can happen is
> that somebody needs to add extra includes in their programs in order for
> them to compile with 8.4.  We do enough other changes that this one is
> really minor.  Better late than never anyway.

Okay, I'll do a trial patch and we can see exactly how much has to be
added (at least among core and contrib) before deciding for sure.
        regards, tom lane