Jim Nasby <Jim.Nasby@bluetreble.com> writes:
> Hmm... I suspect there's more places where this could be a problem. For
> example, pltcl_quote calls palloc, which could ereport as well.
Yeah. I looked at that but couldn't get terribly excited about it,
because AFAICS, Tcl in general is apt to fall over under sufficient
memory pressure. There are too many API functions with no failure
return provision, even though they clearly must do memory allocation
under the hood. (The fact that they've even got ckalloc() tells you
what their philosophy is here: they're content to PANIC on OOM.)
I think pltcl should attempt to cover any error conditions that aren't
purely out-of-memory ones, but in a quick scan I didn't see any other
hazards.
regards, tom lane