Re: [PATCHES] Changes in /contrib/fulltextindex

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: [PATCHES] Changes in /contrib/fulltextindex
Дата
Msg-id 9648.1025532356@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: [PATCHES] Changes in /contrib/fulltextindex  ("Florian Helmberger" <f.helmberger@uptime.at>)
Список pgsql-hackers
"Florian Helmberger" <f.helmberger@uptime.at> writes:
> Just tried your example - you're right of course! I will remove the hard
> coded delimited list and replace it with the proper calls as shown in the
> code you've sent.

Well, that was a quick hack not clean code.  Coding rules for stuff
inside the backend are- don't do setlocale; it's already been done.- explicitly cast the argument of any ctype.h macro
to (unsigned char).
 

Without the latter you have portability problems depending on whether
chars are signed or unsigned.
        regards, tom lane




В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Florian Helmberger"
Дата:
Сообщение: Re: [PATCHES] Changes in /contrib/fulltextindex
Следующее
От: Tom Lane
Дата:
Сообщение: Re: [PATCHES] Changes in /contrib/fulltextindex