AlterTableCreateToastTable API still not right for pg_migrator

Поиск
Список
Период
Сортировка
От Tom Lane
Тема AlterTableCreateToastTable API still not right for pg_migrator
Дата
Msg-id 9564.1244748971@sss.pgh.pa.us
обсуждение исходный текст
Ответы Re: AlterTableCreateToastTable API still not right for pg_migrator  (Bruce Momjian <bruce@momjian.us>)
Re: AlterTableCreateToastTable API still not right for pg_migrator  (Bruce Momjian <bruce@momjian.us>)
Список pgsql-hackers
I just started reading the pg_migrator source code, and I notice that
we still didn't get AlterTableCreateToastTable's API right for
pg_migrator's usage.  It needs to be exposing an option to force
a particular OID for the toast table.  The way pg_migrator is handling
that now is both ugly and unsafe, and it's really pretty silly when the
underlying create_toast_table() function is perfectly capable of being
told what we want it to do.

There's still time to fix this before RC1.  I propose adding
"Oid toastOid" to AlterTableCreateToastTable's arguments, with
the semantics that if it's not InvalidOid then we attempt to create
the toast table with that OID.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Josh Berkus
Дата:
Сообщение: Re: Resolving 8.4 open items
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Modifying TOAST_TUPLE_THRESHOLD and TOAST_TUPLE_TARGET?