Re: WIP: About CMake v2

Yeah, there seems to be a lot of these. Looking through them almost all 
concern the addition of piece of code to wrap putenv. e.g:

--- a/src/bin/psql/command.c
+++ b/src/bin/psql/command.c
@@ -1350,7 +1350,7 @@ exec_command(const char *cmd,                        char       *newval;
                        newval = psprintf("%s=%s", envvar, envval);
-                       putenv(newval);
+                       pg_putenv_proxy(newval);                        success = true;
                        /*

Where pg_putenv_proxy either calls putenv or pgwin32_putenv (the latter 
on windows I'd guess). I wonder if this could have been avoided, since 
the original code handles this sort of thing. There are also some minor 
- and not immediately obvious - changes to a number of macros in various 
includes...If I'm feeling keen I'll experiment to see how far I can get 
without any source changes at all.


regards


Mark


On 09/11/16 08:37, Peter Eisentraut wrote:
>
> There are a number of changes in .[ch] and .pl files that are unclear
> and not explained.  Please explain them.  You can also submit separate
> preliminary patches if you need to do some refactoring.  Ultimately, I
> would expect this patch not to require C code changes.
>