Re: New patch for bugs in GPDB csv format log handling

On Fri, Jun 5, 2009 at 3:40 AM, Chuck McDevitt<cmcdevitt@greenplum.com> wrote:
> This patch fixes many problems in the handling of GPDB CSV format logs for the frmStatus display.
>
> It's also a useful start for supporting PostgreSQL 8.4 CSV format logs.

Hi,

Some issues with this, 2 minor, one less so:

- Please rearrange the code in frmStatus.h to remove the class
definition. We try to keep the headers purely for declarations and
only include one-line functions in them. I would suggest a new file in
utils/ given that it's a generally useful class.

- Status bar messages such as _("Reading log from server.") should
generally end with ... to indicate the task is ongoing.

- Messages passed to wxLogError should be translatable, and explain
the problem to the user without being phrased as a question (wxT("Log
line does not start with timestamp?: %s \n")). Messages passed to
wxLogNotice needn't be translated however.

Regards, Dave.

--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com