Re: Server Status window work

On Thu, Feb 12, 2009 at 11:09 PM, Guillaume Lelarge
<guillaume@lelarge.info> wrote:

> The patch attached takes care of this. It's not really finished but it
> gives an idea of what could be done. There's also the combo stuff. I
> would love to get comments on this, to see if I go further.

I immediately got an assertion (well, four):

---------------------------
wxWidgets Debug Alert
---------------------------
..\..\src\msw\registry.cpp(961): assert "!IsNumericValue(szValue)"
failed in wxRegKey::QueryValue(): Type mismatch in
wxRegKey::QueryValue().

Call stack:
[00] wxGUIAppTraitsBase::ShowAssertDialog
    c:\pgbuild\wxwidgets\src\common\appcmn.cpp:635
[01] ShowAssertDialog
    c:\pgbuild\wxwidgets\src\common\appbase.cpp:836
[02] wxAppConsole::OnAssertFailure
    c:\pgbuild\wxwidgets\src\common\appbase.cpp:445
[03] wxOnAssert
    c:\pgbuild\wxwidgets\src\common\appbase.cpp:713
[04] wxRegKey::QueryValue
    c:\pgbuild\wxwidgets\src\msw\registry.cpp:961
[05] wxRegKey::QueryValue
    c:\pgbuild\wxwidgets\include\wx\msw\registry.h:167
[06] TryGetValue
    c:\pgbuild\wxwidgets\src\msw\regconf.cpp:48
[07] wxRegConfig::DoReadString
    c:\pgbuild\wxwidgets\src\msw\regconf.cpp:578
[08] wxConfigBase::Read
    c:\pgbuild\wxwidgets\src\common\config.cpp:143
[09] sysSettings::Read
    c:\pgbuild\buildtrees\pgadmin3\pgadmin\utils\syssettings.cpp:266
[10] frmStatus::AddStatusPage
    c:\pgbuild\buildtrees\pgadmin3\pgadmin\frm\frmstatus.cpp:379
[11] frmStatus::frmStatus
    c:\pgbuild\buildtrees\pgadmin3\pgadmin\frm\frmstatus.cpp:220
[12] serverStatusFactory::StartDialog
    c:\pgbuild\buildtrees\pgadmin3\pgadmin\frm\frmstatus.cpp:1824
[13] frmMain::OnAction
    c:\pgbuild\buildtrees\pgadmin3\pgadmin\frm\events.cpp:147
[14] wxAppConsole::HandleEvent
    c:\pgbuild\wxwidgets\src\common\appbase.cpp:323
[15] wxEvtHandler::ProcessEventIfMatches
    c:\pgbuild\wxwidgets\src\common\event.cpp:1233
[16] wxEvtHandler::SearchDynamicEventTable
    c:\pgbuild\wxwidgets\src\common\event.cpp:1413
[17] wxEvtHandler::ProcessEvent
    c:\pgbuild\wxwidgets\src\common\event.cpp:1289
[18] wxEvtHandler::ProcessEvent
    c:\pgbuild\wxwidgets\src\common\event.cpp:1300
[19] wxFrameBase::ProcessCommand
    c:\pgbuild\wxwidgets\src\common\framecmn.cpp:224
[20] wxFrame::HandleCommand
    c:\pgbuild\wxwidgets\src\msw\frame.cpp:978
Do you want to stop the program?
You can also choose [Cancel] to suppress further warnings.
---------------------------
Yes   No   Cancel
---------------------------

I suspect, that was because of the existing refresh rate(s) being
stored in the registry.

Aside from that, I quite like this layout :-) A few thoughts, in no
particular order:

- The layout is not being restored when the window is re-opened.
Should be easy to do - the code already exists in other forms.

- The main pane on the right should perhaps be the log pane, as thats
the one that will usually have lots of info in it, even on a developer
system with no other users.

- Can we move the per-pane controls to a single toolbar at the top of
the form, and have that display only the controls for the active pane?
That would be a lot tidier I think, and would largely solve the
pane-too-small-tools-truncated-or-obscured problem. There is a flag to
the AUI manager to have it highlight the top bar of the active pane
iirc, so it should be obvious which pane a user would be modifying.


--
Dave Page
EnterpriseDB UK:   http://www.enterprisedb.com