Re: Missing CFI in iterate_word_similarity()

Поиск
Список
Период
Сортировка
Искать
От
Tom Lane
Тема
Re: Missing CFI in iterate_word_similarity()
Дата
Msg-id
937735.1662123420@sss.pgh.pa.us
Ответ на
Список
Дерево обсуждения
Missing CFI in iterate_word_similarity() Robins Tharakan <tharakan@gmail.com>
Re: Missing CFI in iterate_word_similarity() Daniel Gustafsson <daniel@yesql.se>
Re: Missing CFI in iterate_word_similarity() Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing CFI in iterate_word_similarity() Daniel Gustafsson <daniel@yesql.se>
Re: Missing CFI in iterate_word_similarity() Tom Lane <tgl@sss.pgh.pa.us>
Re: Missing CFI in iterate_word_similarity() Daniel Gustafsson <daniel@yesql.se>
Re: Missing CFI in iterate_word_similarity() Daniel Gustafsson <daniel@yesql.se>
Daniel Gustafsson  writes:
> Placing code before declarations will generate a compiler warning, so the check
> must go after trgindex is declared.  I've fixed that in the attached to get the
> cfbot green.  Marking this ready for committer in the meantime.

I noticed the same thing, but sticking the CFI immediately after the
declaration didn't read well either.  I was considering moving it to
the bottom of the loop instead of that.  A possible objection is that
if there's ever a "continue;" in the loop, those iterations would bypass
the CFI; but we don't necessarily need a CFI every time.

			regards, tom lane


В списке pgsql-hackers по дате отправления
От: Alvaro Herrera
Дата:
От: Daniel Gustafsson
Дата:
FAQ