Daniel Gustafsson <daniel@yesql.se> writes:
> Placing code before declarations will generate a compiler warning, so the check
> must go after trgindex is declared. I've fixed that in the attached to get the
> cfbot green. Marking this ready for committer in the meantime.
I noticed the same thing, but sticking the CFI immediately after the
declaration didn't read well either. I was considering moving it to
the bottom of the loop instead of that. A possible objection is that
if there's ever a "continue;" in the loop, those iterations would bypass
the CFI; but we don't necessarily need a CFI every time.
regards, tom lane