Re: RULE regression test fragility?

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: RULE regression test fragility?
Дата
Msg-id 9374.1382575830@sss.pgh.pa.us
обсуждение исходный текст
Ответ на RULE regression test fragility?  (Mike Blackwell <mike.blackwell@rrd.com>)
Ответы Re: RULE regression test fragility?  (Andres Freund <andres@2ndquadrant.com>)
Список pgsql-hackers
Mike Blackwell <mike.blackwell@rrd.com> writes:
> While reviewing the Network Stats Traffic patch I discovered the current
> regression test for rules depends on the system view definitions not
> changing:

Yes, this is standard.  We just update the expected output anytime
somebody changes a system view.

(Now, if the submitter failed to notice that his patch broke the
regression tests, that's grounds to wonder how much he tested it.
But it's not unexpected for that test's output to change.)

> [ Is it really a good idea for the regression tests to do that? ]

I tend to think so, as it seems like a good stress test for the
rule-dumping machinery.
        regards, tom lane



В списке pgsql-hackers по дате отправления:

Предыдущее
От: Peter Geoghegan
Дата:
Сообщение: Re: Add min and max execute statement time in pg_stat_statement
Следующее
От: Gordon Mohr
Дата:
Сообщение: high-dimensional knn-GIST tests (was Re: Cube extension kNN support)