David Rowley <dgrowleyml@gmail.com> writes:
> I'm currently not sure why the macro trick increases the binary at
> all. I understand why the inline function does.
In the places where it changes the code at all, you're replacing
appendStringInfoString(buf, s);
with
appendBinaryStringInfo(buf, s, n);
Even if n is a constant, the latter surely requires more instructions
per call site.
Whether this is a win seems to depend on how many of these are
performance-critical.
regards, tom lane