Ants Aasma <ants@cybertec.at> writes:
> On Tue, Apr 16, 2013 at 5:05 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
>> My only review comments are to ask for some explanation of the magic numbers...
> The specific values used are mostly magic to me too. As mentioned in a
> short sentence in the patch, the values are experimentally chosen,
> guided by some intuition about what good values should look like.
There actually is quite a lot of theory out there about this sort of
thing. If we are inventing our own checksum function then We're Doing
It Wrong. We should be adopting an existing, proven function.
"Experimentally derived" is about the worst recommendation I can think
of in this area.
regards, tom lane