Re: Large expressions in indexes can't be stored (non-TOASTable)

Nathan Bossart <nathandbossart@gmail.com> writes:
> On Mon, Apr 28, 2025 at 05:35:08PM -0400, Tom Lane wrote:
>> Possibly better idea: can we add something like
>> Assert(!OidIsValid(reltoastrelid)) in the code that is making this
>> assumption?

> Yeah, we could add something like that to replorigin_create() pretty
> easily.  The comment for that would be even harder to miss.

Maybe one more sentence in the code comment so that the logic is
easier to follow:

+    /*
+     * We want to be able to access pg_replication_origin without setting up a
+     * snapshot.  To make that safe, it needs to not have a TOAST table,
+     * since TOASTed data cannot be fetched without a snapshot.  As of this
+     * writing, ...

LGTM other than that nit.

            regards, tom lane