On Apr 23, 2009, at 12:22 AM, Heikki Linnakangas wrote:
> Zdenek Kotala wrote:
>> It seems to me that citex_cmp can return any integer value. It
>> depends
>> what wcscoll() returns. I think it should be changed to:
>> SELECT citext_cmp('B'::citext, 'a'::citext) > 0 AS one;
>
> The comment in varstr_cmp() claims that it returns -1, 0 or 1.
> That's not accurate then.
>
> Comment and test case fixed. I considered changing varstr_cmp to
> really return -1, 0 or 1, but I didn't because the behavior has been
> unchanged for ages and all the callers are happy with it. That's a
> heavily called function so any extra cycles there could make a
> difference.
Thanks, I also changed it in my version for 8.3.
https://svn.kineticode.com/citext/trunk/
Best,
David