Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)
Дата
Msg-id 901577.1756930252@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Re: BUG #18960: Mistake in test test_simple_pipeline (libpq_pipeline.c)  (Álvaro Herrera <alvherre@kurilemu.de>)
Список pgsql-bugs
=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de> writes:
> On 2025-Sep-03, Tom Lane wrote:
>> Hm, I chose that name by analogy to the adjacent
>> confirm_query_canceled(), which is likewise consuming a result.
>> I agree that "consume" is a better verb, but then let's rename
>> confirm_query_canceled as well.

> Ah, that explains it -- my bad, then, I suppose.  That change works for
> me.

After reflection, I used "consume_xxx" for the void-returning helper
functions, but kept the "confirm_xxx" terminology for the helper
function that returns a PGresult after confirming its status is
as-expected.  Pushed with those renamings.

            regards, tom lane



В списке pgsql-bugs по дате отправления: