On 21.07.21 04:21, Michael Paquier wrote:
> On Tue, Jul 20, 2021 at 05:08:53PM +0200, Peter Eisentraut wrote:
>> While reviewing the logical decoding of sequences patch, I found a few more
>> places that could be updated in the new style introduced by this thread.
>> See attached patch.
>
> Those changes look fine. I am spotting one instance in
> init_sequence() that looks worth aligning with the others?
I think if you write "ALTER SEQUENCE foo", then "foo is not a sequence"
would be an appropriate error message, so this doesn't need changing.
> Did you consider changing RangeVarCallbackForAlterRelation() or
> ExecGrant_Relation() when it came to this thread? Just noticing that,
> while going through the code.
These might be worth another look, but I'd need to investigate more in
what situations they happen.