Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()

Поиск
Список
Период
Сортировка
От Peter Eisentraut
Тема Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()
Дата
Msg-id 8ff1cfd7-7b30-9e10-84d7-f68123c5e2b2@2ndquadrant.com
обсуждение исходный текст
Ответ на Re: pgsql: Increase test coverage in RI_FKey_pk_upd_check_required()  ("David G. Johnston" <david.g.johnston@gmail.com>)
Список pgsql-committers
On 16/01/2019 17:39, David G. Johnston wrote:
> On Wednesday, January 16, 2019, Peter Eisentraut <peter@eisentraut.org
> <mailto:peter@eisentraut.org>> wrote:
> 
>     Increase test coverage in RI_FKey_pk_upd_check_required()
> 
>     This checks the case where the primary key has at least one null
>     column.
> 
> 
> Sorry if this seems pedantic but you are testing where a unique index
> has at least one null column value.  A primary key, per the docs, cannot
> contain null in any of its columns.  I read the commit message and
> thought maybe that had changed while I wasn’t looking...

Yeah, it's the foreign key referencing the primary key in this case.

You are correct, the message is a bit wrong.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


В списке pgsql-committers по дате отправления:

Предыдущее
От: Alvaro Herrera
Дата:
Сообщение: pgsql: Reorganize planner code moved in b60c39759908
Следующее
От: Etsuro Fujita
Дата:
Сообщение: pgsql: postgres_fdw: Remove duplicate code in DML execution callbackfu