On 23.06.22 09:41, Markus Wanner wrote:
>
> On 6/21/22 18:33, Tom Lane wrote:
>> My inclination at this point is to not back-patch the second change
>> 12d768e70 ("Don't use static storage for
>> SaveTransactionCharacteristics").
>> It's not clear that the benefit would be worth even a small risk of
>> somebody being unhappy about the API break.
>
> Actually, the backport of 2e517818f ("Fix SPI's handling of errors")
> already broke the API for code using SPICleanup, as that function had
> been removed. Granted, it's not documented, but still exported.
>
> I propose to re-introduce a no-op placeholder similar to what we have
> for SPI_start_transaction, somewhat like the attached patch.
I have applied your patch to branches 11 through 14.