Re: consider -Wmissing-variable-declarations

On 28.08.24 05:31, Thomas Munro wrote:
> On Wed, Jun 19, 2024 at 3:02 AM Andres Freund <andres@anarazel.de> wrote:
>>> -const char *EAN13_range[][2] = {
>>> +static const char *EAN13_range[][2] = {
>>>        {"000", "019"},                         /* GS1 US */
>>>        {"020", "029"},                         /* Restricted distribution (MO defined) */
>>>        {"030", "039"},                         /* GS1 US */
>>
>>> -const char *ISBN_range[][2] = {
>>> +static const char *ISBN_range[][2] = {
>>>        {"0-00", "0-19"},
>>>        {"0-200", "0-699"},
>>>        {"0-7000", "0-8499"},
>>> @@ -967,7 +967,7 @@ const char *ISBN_range[][2] = {
>>>    */
> 
> FYI these ones generate -Wunused-variable warnings from headerscheck
> on CI, though it doesn't fail the task.  Hmm, these aren't really
> headers, are they?

Yes, it looks like these ought to be excluded from checking:

diff --git a/src/tools/pginclude/headerscheck 
b/src/tools/pginclude/headerscheck
index 436e2b92a33..3fc737d2cc1 100755
--- a/src/tools/pginclude/headerscheck
+++ b/src/tools/pginclude/headerscheck
@@ -138,6 +138,12 @@ do
     test "$f" = src/pl/tcl/pltclerrcodes.h && continue

     # Also not meant to be included standalone.
+   test "$f" = contrib/isn/EAN13.h && continue
+   test "$f" = contrib/isn/ISBN.h && continue
+   test "$f" = contrib/isn/ISMN.h && continue
+   test "$f" = contrib/isn/ISSN.h && continue
+   test "$f" = contrib/isn/UPC.h && continue
+
     test "$f" = src/include/common/unicode_nonspacing_table.h && continue
     test "$f" = src/include/common/unicode_east_asian_fw_table.h && 
continue