Re: Emit extra debug message when executing extension script.

Поиск
Список
Период
Сортировка
От Jeff Davis
Тема Re: Emit extra debug message when executing extension script.
Дата
Msg-id 8e4e1d3c330828abe73b9a587607587ad87539c9.camel@j-davis.com
обсуждение исходный текст
Ответ на Re: Emit extra debug message when executing extension script.  (Nathan Bossart <nathandbossart@gmail.com>)
Список pgsql-hackers
On Fri, 2022-07-01 at 15:33 -0700, Nathan Bossart wrote:
> On Fri, Jul 01, 2022 at 03:24:27PM -0700, Jeff Davis wrote:
> > +        ereport(DEBUG1, errmsg("executing extension update
> > script from version '%s' to '%s'", from_version, version));
> 
> nitpick: I would suggest "executing extension script for update from
> version X to Y."

Thank you. Committed with minor modification to include the extension
name.

I did end up using Peter's suggestion. I reviewed other DEBUG messages
and it seems nearly all use elog() or errmsg_internal().

> I personally would rather this output the name of the file.  If
> revealing
> the directory is a concern, perhaps we could just trim everything but
> the
> file name.

I could have slightly refactored the code to do this, but it didn't
quite seem worth it for a single debug message.

Regards,
    Jeff Davis





В списке pgsql-hackers по дате отправления:

Предыдущее
От: Andres Freund
Дата:
Сообщение: AIX support - alignment issues
Следующее
От: Tom Lane
Дата:
Сообщение: Re: Probable memory leak with ECPG and AIX