Re: Review for GetWALAvailability()

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: Review for GetWALAvailability()
Дата
Msg-id 8dcae742-7892-ad82-b787-1ac05cb878d8@oss.nttdata.com
обсуждение исходный текст
Ответ на Re: Review for GetWALAvailability()  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Список pgsql-hackers

On 2020/06/18 16:36, Kyotaro Horiguchi wrote:
> Mmm. I hurried too much..
> 
> At Thu, 18 Jun 2020 16:32:59 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
>> If name is specified (so slot is NULL) to
>> ReplicationSlotAcquireInternal and the slot is not found, the ereport
>> in following code dereferences NULL.
> 
> That's bogus. It is using name in that case. Sorry for the noise.
> 
> I don't find a problem by a brief look on it.

Thanks for the review! I pushed the patch.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "Andrey V. Lepikhov"
Дата:
Сообщение: Re: Global snapshots
Следующее
От: Andy Fan
Дата:
Сообщение: hash as an search key and hash collision