Re: PATCH: Fail to restore table/function, if it has special characters.

Поиск
Список
Период
Сортировка
От Ashesh Vashi
Тема Re: PATCH: Fail to restore table/function, if it has special characters.
Дата
Msg-id 8cf965d31003180719w1726bda2u4713cbe69b7a4894@mail.gmail.com
обсуждение исходный текст
Ответ на Re: PATCH: Fail to restore table/function, if it has special characters.  (Dave Page <dave.page@enterprisedb.com>)
Ответы Re: PATCH: Fail to restore table/function, if it has special characters.
Список pgadmin-hackers
Hi,

The bug was also there for the windows. :-(
I had to modify the commandLineCleanOption function to resolve the issue and to make it platform-independent.

Please find the attached patch for the same.

I have made changes in the following files as described:
* include/utils/misc.h
- Changed the definition of the "commandLineCleanOption" function
* utils/misc.cpp
- Changed the "commandLineCleanOption" function to make it work on any platform.
/**
 * FUNCTION: commandLineCleanOption
 * INPUTS:
 *       option       - input string needs to be reformatted
 *       schemaObject - Is this an object related to schema?
 * PURPOSE:
 *  - Fixup a (double-quoted) string for use on the command line
 *
 *    1. Schema objects needs three (slash & double-quote) combination
 *       instead of a double-quote to be used as a command-line option
 *    2. Options other than the schema objects needs (slash & double-quote)
 *       combination instead of a double-quote to be used as a command-line
 *       option.
 *
 *    i.e. CASE: Dump a table named em"p and database name tes"t having username
 *         xy\z. The command-line arguments for these values will be as below:
 *
 *         pg_dump --username "xy\\z" --table public."em\"\"\"p" "tes\"t"
 */
The above comments says everything about its implementation.
* frm/frmBackup.cpp
* frm/frmBackupGlobals.cpp
* frm/frmBackupServer.cpp
* frm/frmRestore.cpp

Dave,

In order the solve this issue on 1_10_PATCHES branch, we may need to do the similar refactoring.
Is it ok?
If yes, I can share the patch for the same.

--

Ashesh Vashi
EnterpriseDB INDIA: Enterprise Postgres Company

Вложения

В списке pgadmin-hackers по дате отправления:

Предыдущее
От: svn@pgadmin.org
Дата:
Сообщение: SVN Commit by dpage: r8231 - trunk/pgadmin3
Следующее
От: Dave Page
Дата:
Сообщение: Re: PATCH: Fail to restore table/function, if it has special characters.