Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo

Поиск
Список
Период
Сортировка
От Fujii Masao
Тема Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo
Дата
Msg-id 8bb8426f-0bc1-1b98-9e2a-ca1c1be25acf@oss.nttdata.com
обсуждение исходный текст
Ответ на Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo  (torikoshia <torikoshia@oss.nttdata.com>)
Ответы Re: Modifying data type of slot_keep_segs from XLogRecPtr to XLogSegNo  (torikoshia <torikoshia@oss.nttdata.com>)
Список pgsql-hackers

On 2020/07/08 11:02, torikoshia wrote:
> Hi,
> 
> Currently, slot_keep_segs is defined as "XLogRecPtr" in KeepLogSeg(),
> but it seems that should be "XLogSegNo" because this variable is
> segment number.
> 
> How do you think?

I agree that using XLogRecPtr for slot_keep_segs is incorrect.
But this variable indicates the number of segments rather than
segment no, uint64 seems better. Thought?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION



В списке pgsql-hackers по дате отправления:

Предыдущее
От: "movead.li@highgo.ca"
Дата:
Сообщение: Re: A patch for get origin from commit_ts.
Следующее
От: Fujii Masao
Дата:
Сообщение: Re: [doc] modifying unit from characters to bytes