Re: Win32 GiST bug - more info

Hi Tom/Win32 hackers,

Just to clarify this thread and let you know that Tom was correct - I
didn't notice that a recent commit to the GiST code had altered part of
the API that was causing the crash. Our Linux development box runs an
older CVS snapshot and so we didn't notice.... don't suppose there's any
way of having the compiler throw an error on this?

So in short, GiST indices work fine in Win32 :)


Cheers,

Mark.

---

Mark Cave-Ayland
Webbased Ltd.
Tamar Science Park
Derriford
Plymouth
PL6 8BX
England

Tel: +44 (0)1752 764445
Fax: +44 (0)1752 764446


This email and any attachments are confidential to the intended
recipient and may also be privileged. If you are not the intended
recipient please delete it from your system and notify the sender. You
should not copy it or use it for any purpose nor disclose or distribute
its contents to any other person.

> -----Original Message-----
> From: Tom Lane [mailto:tgl@sss.pgh.pa.us]
> Sent: 26 May 2004 17:02
> To: Mark Cave-Ayland
> Cc: pgsql-hackers-win32@postgresql.org
> Subject: Re: [pgsql-hackers-win32] Win32 GiST bug - more info
>
>
> "Mark Cave-Ayland" <m.cave-ayland@webbased.co.uk> writes:
> > Thanks for your reply. I found that I got a "better" backtrace by
> > executing a couple of commands in the psql.exe session
> before creating
> > the index. The improved backtrace was given below:
>
> Ah, I think I know the problem: you haven't updated your code
> to conform to the recently-revised API for GIST index support
> functions.  You need to look at these diffs:
>
> 2004-03-30 10:45  teodor
>
>     * contrib/btree_gist/btree_common.c,
>     contrib/btree_gist/btree_gist.h,
>     contrib/btree_gist/btree_gist.sql.in,
>     contrib/btree_gist/btree_num.c.in,
> contrib/btree_gist/btree_ts.c,
>     contrib/cube/cube.c, contrib/cube/cube.sql.in,
>     contrib/intarray/_int.sql.in, contrib/intarray/_int_gist.c,
>     contrib/intarray/_intbig_gist.c, contrib/ltree/_ltree_gist.c,
>     contrib/ltree/ltree.sql.in, contrib/ltree/ltree_gist.c,
>     contrib/rtree_gist/rtree_gist.c,
>     contrib/rtree_gist/rtree_gist.sql.in, contrib/seg/seg.c,
>     contrib/seg/seg.sql.in, contrib/tsearch/gistidx.c,
>     contrib/tsearch/tsearch.sql.in, contrib/tsearch2/gistidx.c,
>     contrib/tsearch2/tsearch.sql.in,
> contrib/tsearch2/untsearch.sql.in,
>     src/backend/access/gist/gist.c,
> src/include/access/gist.h: Cleanup
>     vectors of GISTENTRY and eliminate problem with 64-bit
>     strict-aligned boxes. Change interface to user-defined
> GiST support
>     methods union and picksplit. Now instead of bytea struct it used
>     special GistEntryVector structure.
>
> There should be some discussion in the pgsql-hackers archives, too.
>
> I think the direct cause of the crash is you're computing the
> wrong number of elements in the passed GISTENTRY vector and
> iterating off the end of the actually allocated vector.
>
>             regards, tom lane
>