Re: ANALYZE patch for review

> -----Original Message-----
> From: pgsql-patches-owner@postgresql.org
> [mailto:pgsql-patches-owner@postgresql.org] On Behalf Of Tom Lane
> Sent: 13 February 2004 14:41
> To: Mark Cave-Ayland
> Cc: pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] ANALYZE patch for review
>
>
> "Mark Cave-Ayland" <m.cave-ayland@webbased.co.uk> writes:
> > The only reason I kept the Relation parameter
> > was because I wasn't sure if there was a historical reason
> why someone
> > would need the relation information as well as the attribute
> > information.
>
> I can't think of one, but if someone did, they could extract
> the relation OID from the pg_attribute row and re-open it for
> themselves. So AFAICS this API does not omit any critical info.

Great.

> I forgot to email you about the fetch_function revision, but
> I trust it meets with your approval.  Right now it's just a
> wrapper around heap_fetch, but I thought we might conceivably
> want something different when we do functional-index stats.
> The fetch function will give us wiggle room if we need it.

Yep no problems as long as the functionality is there. I think I can
also see where you're going with functional indexes - during an analyze
phase, for a column X, a pseudo-column f(X) is generated from the sample
data before the stats calculation is performed and the results dropped
into pg_statistic. Hopefully this now shouldn't be too difficult for
someone to pick it up and run with it.


Cheers,

Mark.

---

Mark Cave-Ayland
Webbased Ltd.
Tamar Science Park
Derriford
Plymouth
PL6 8BX
England

Tel: +44 (0)1752 764445
Fax: +44 (0)1752 764446


This email and any attachments are confidential to the intended
recipient and may also be privileged. If you are not the intended
recipient please delete it from your system and notify the sender. You
should not copy it or use it for any purpose nor disclose or distribute
its contents to any other person.