On 10/6/21, 1:34 PM, "Magnus Hagander" <magnus@hagander.net> wrote:
> I definitely think that's the way to go. It gives a single path for everything which makes it simpler in the most
criticalparts. And once you have picked an implementation other than it, you're now completely rid of the old
implementation. And of course the good old idea that having an extension already using the API is a good way to show
thatthe API is in a good place.
>
> As much as I dislike our current interface in archive_command, and would like to see it go away completely, I do
believewe need to ship something that has it - if nothing else then for backwards compatibility. But an extension like
thiswould also make it easier to eventually, down the road, deprecate this solution.
>
> Oh, and please put said implementation in a better place than contrib :)
I've attached an attempt at moving the archive_command logic to its
own module and replacing it with a hook. This was actually pretty
straightforward.
I think the biggest question is where to put the archive_command
module, which I've called shell_archive. The only existing directory
that looked to me like it might work is src/test/modules. It might be
rather bold to relegate this functionality to a test module so
quickly, but on the other hand, perhaps it's the right thing to do
given we intend to deprecate it in the future. I'm curious what
others think about this.
I'm still working on the documentation updates, which are quite
extensive. I haven't included any of those in the patch yet.
Nathan