Re: trivial improvement to system_or_bail

Поиск
Список
Период
Сортировка
От Daniel Gustafsson
Тема Re: trivial improvement to system_or_bail
Дата
Msg-id 8AC32042-183D-452B-9B18-AA150BC99621@yesql.se
обсуждение исходный текст
Ответ на trivial improvement to system_or_bail  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Ответы Re: trivial improvement to system_or_bail  (Alvaro Herrera <alvherre@alvh.no-ip.org>)
Список pgsql-hackers
> On 30 Jun 2021, at 17:24, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> When PostgresNode::system_or_bail() fails, it's quite opaque as to what
> is happening.  This patch improves things by printing some detail, as
> suggested in Perl's doc for system().

+1 on this from reading the patch.

+            BAIL_OUT("system $_[0] failed: $!\n");
I wonder if we should take more inspiration from the Perl manual and change it
to "failed to execute" to make it clear that the failure was in executing the
program, not from the program itself?

--
Daniel Gustafsson        https://vmware.com/




В списке pgsql-hackers по дате отправления:

Предыдущее
От: Fabien COELHO
Дата:
Сообщение: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Следующее
От: Tom Lane
Дата:
Сообщение: Re: trivial improvement to system_or_bail