On 26 November 2013 23:11 Fujii Masao wrote:
> On Wed, Nov 20, 2013 at 7:43 PM, Haribabu kommi
> <haribabu.kommi@huawei.com> wrote:
> > I tried using of stat'ing in two directories, which is having a
> problem in windows.
> > So modified old approach to detect limited errors. Updated patch
> attached.
> > This will detect and throw an error in the following scenarios.
> > 1. pg_basebackup -D /home/data --xlogdir=/home/data 2. pg_basebackup
> > -D data --xlogdir=/home/data -- home is the CWD 3. pg_basebackup -D
> > ../data --xlogdir=/data -- home is the CWD
> >
> > Please let me know your suggestions.
>
> Checking only #1 and #2 cases looks sufficient to at least me. If we do
> that, we can refactor the patch so that it reuses make_absolute_path()
> instead of adding new functions, as pointed in upthread. Anyway, what
> about committing the core patch (Updated version of core patch attached)
> first? Then, we can discuss the check logic more.
Yes it is fine. The core patch attached in the mail is working fine.
I will provide another patch with check logic by incorporating your suggestions.
Regards,
Hari babu.