Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)
Дата
Msg-id 8963.1332432615@sss.pgh.pa.us
обсуждение исходный текст
Ответ на Trivial libpq refactoring patch (was: Re: Another review of URI for libpq, v7 submission)  (Alex Shulgin <ash@commandprompt.com>)
Список pgsql-hackers
Alex Shulgin <ash@commandprompt.com> writes:
> While working on this fix I've figured out that I need my
> conninfo_uri_parse to support use_defaults parameter, like
> conninfo(_array)_parse functions do.

> The problem is that the block of code which does the defaults handling
> is duplicated in both of the above functions.  What I'd like to do is
> extract it into a separate function to call.  What I wouldn't like is
> bloating the original URI patch with this unrelated change.

Applied with minor adjustments --- notably, I thought
conninfo_add_defaults was a better name for the function.
        regards, tom lane


В списке pgsql-hackers по дате отправления:

Предыдущее
От: Robert Haas
Дата:
Сообщение: Re: HOT updates & REDIRECT line pointers
Следующее
От: "Kevin Grittner"
Дата:
Сообщение: Re: Gsoc2012 Idea --- Social Network database schema