Hi,
Correct me if I’m wrong.
The doc says we don’t take lock during pg_buffercache_summary, but I see locks in the v8 patch, Isn’t it?
```
Similar to <function>pg_buffercache_pages</function> function
<function>pg_buffercache_summary</function> doesn't take buffer manager
locks, thus the result is not consistent across all buffers. This is
intentional. The purpose of this function is to provide a general idea about
the state of shared buffers as fast as possible. Additionally,
<function>pg_buffercache_summary</function> allocates much less memory.
```
On Sep 20, 2022, 20:10 +0800, Melih Mutlu <m.melihmutlu@gmail.com>, wrote:
Hi,
Seems like cfbot tests are passing now:
Best,
Melih
There was a missing empty line in pg_buffercache.out which made the
tests fail. Here is a corrected v8 patch.
I was just sending a corrected patch without the missing line.
Thanks a lot for all these reviews and the corrected patch.
Best,
Melih