Re: implement query_start for pg_stat_activity

Поиск
Список
Период
Сортировка
От Tom Lane
Тема Re: implement query_start for pg_stat_activity
Дата
Msg-id 8839.1045634691@sss.pgh.pa.us
обсуждение исходный текст
Ответ на implement query_start for pg_stat_activity  (Neil Conway <neilc@samurai.com>)
Ответы Re: implement query_start for pg_stat_activity  (Neil Conway <neilc@samurai.com>)
Список pgsql-patches
Neil Conway <neilc@samurai.com> writes:
> (1) The natural name for the backend function is
> pg_stat_get_backend_activity_start(), which at 34 exceeds the
> NAMEDATALEN limitation in previous releases of PostgreSQL. While that
> limit has been raised, it seems a shame to me to not allow users to
> manual lower it again -- so I renamed the function to
> pg_stat_get_backend_qry_start(), and renamed the existing function that
> fetches the query string from pg_stat_get_backend_activity() to
> pg_stat_get_backend_qry() for consistency. If someone thinks that's the
> wrong decision, let me know.

NAMEDATALEN=32 will have been history for two releases when this gets
out.  I don't agree with artificially constricting a function name to
conform to an obsolete restriction --- and for *sure* I don't agree with
renaming an existing function to make it line up with a new, artificial
name ...

> (2) I wasn't sure how to convert a struct timeval into a PostgreSQL
> timestamp type, so I hacked something together involving ctime() and
> timestamp_in(), but it seems clearly wrong.

GetCurrentAbsoluteTimeUsec() followed by now() seem to do it at the
moment ... but they do look pretty historically encumbered themselves.
Care to offer a proposal for simplifying this code?

            regards, tom lane

В списке pgsql-patches по дате отправления:

Предыдущее
От: Neil Conway
Дата:
Сообщение: implement query_start for pg_stat_activity
Следующее
От: Neil Conway
Дата:
Сообщение: Re: implement query_start for pg_stat_activity