> I am attaching the patch I BACKED HOW, so the user can see if it is in
> their tree. It should not be ther.
I see the problem with that patch: it's assuming that the old value is
necessarily a pointer to something. For pass-by-value types (eg int4),
it ain't.
regards, tom lane