Re: A out of date comment of WaitForWALToBecomeAvailable

Поиск
Список
Период
Сортировка
От Andy Fan
Тема Re: A out of date comment of WaitForWALToBecomeAvailable
Дата
Msg-id 87zf4pu4ca.fsf@163.com
обсуждение исходный текст
Ответ на Re: Re: A out of date comment of WaitForWALToBecomeAvailable  (Michael Paquier <michael@paquier.xyz>)
Список pgsql-hackers
Hi All,

> [[PGP Signed Part:Undecided]]
> On Mon, Feb 02, 2026 at 10:37:43AM +0800, Xuneng Zhou wrote:
>> WaitForWALToBecomeAvailable can also return XLREAD_WOULDBLOCK when the
>> caller set nonblocking. The comment only talks about XLREAD_FAIL vs
>> “waits in standby,” so it still doesn’t describe that third outcome.
>> That omission pre-dates this patch, should we expand the comment
>> mention the nonblocking case as well?
>
> The outcome related to XLREAD_WOULDBLOCK is implied in the last
> sentence of the comment block standing at the top of the function,
> which seems OK to me.

Thank you for the double check, I personally prefer to keep
XLREAD_WOULDBLOCK as it it.

--
Best Regards
Andy Fan




В списке pgsql-hackers по дате отправления: